Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collect-smartctl-json: shell fixes for script #178

Merged
merged 1 commit into from
Nov 20, 2023
Merged

collect-smartctl-json: shell fixes for script #178

merged 1 commit into from
Nov 20, 2023

Conversation

k0ste
Copy link
Contributor

@k0ste k0ste commented Nov 19, 2023

Shellcheck script & fix issue for SATA Intel SSD:

Collecting data for '/dev/sda'...       Saving to sat-Intel_S4510/S4610/S4500/S4600_Series_SSDs-INTEL_SSDSC2KG480G8-sda.json
collect-smartctl-json.sh: line 54: /tmp/smartctl-data/sat-Intel_S4510/S4610/S4500/S4600_Series_SSDs-INTEL_SSDSC2KG480G8-sda.json: No such file or directory

->

[root@ceph-osd2 tmp]# bash collect-smartctl-json.sh
Collecting data for '/dev/sda'...       Saving to sat-Intel_S4510_S4610_S4500_S4600_Series_SSDs-INTEL_SSDSC2KG480G8-sda.json
Collecting data for '/dev/sdb'...       Saving to sat-Intel_S4510_S4610_S4500_S4600_Series_SSDs-INTEL_SSDSC2KG480G8-sdb.json
Collecting data for '/dev/nvme0'...     Saving to nvme-null-Micron_7400_MTFDKCB3T8TDZ-nvme0.json
Collecting data for '/dev/nvme1'...     Saving to nvme-null-Micron_7400_MTFDKCB3T8TDZ-nvme1.json
Collecting data for '/dev/nvme2'...     Saving to nvme-null-Micron_7400_MTFDKCB3T8TDZ-nvme2.json
Collecting data for '/dev/nvme3'...     Saving to nvme-null-Micron_7400_MTFDKCB3T8TDZ-nvme3.json
Collecting data for '/dev/nvme4'...     Saving to nvme-null-INTEL_SSDPF2KX038TZ-nvme4.json
Collecting data for '/dev/nvme5'...     Saving to nvme-null-INTEL_SSDPF2KX038TZ-nvme5.json
Collecting data for '/dev/nvme6'...     Saving to nvme-null-INTEL_SSDPF2KX038TZ-nvme6.json
Collecting data for '/dev/nvme7'...     Saving to nvme-null-INTEL_SSDPF2KX038TZ-nvme7.json
Collecting data for '/dev/nvme8'...     Saving to nvme-null-INTEL_SSDPF2KX038TZ-nvme8.json
Collecting data for '/dev/nvme9'...     Saving to nvme-null-INTEL_SSDPF2KX038TZ-nvme9.json
Collecting data for '/dev/nvme10'...    Saving to nvme-null-INTEL_SSDPE2KX040T8-nvme10.json
Collecting data for '/dev/nvme11'...    Saving to nvme-null-Micron_7450_MTFDKCC3T8TFR-nvme11.json

@SuperQ SuperQ merged commit 9db6746 into prometheus-community:master Nov 20, 2023
2 checks passed
SuperQ added a commit that referenced this pull request Mar 3, 2024
@SuperQ
Release v0.12.0
a60837f 
* [CHANGE] Better SCSI/SAS support, and removing confused metrics #168
* [ENHANCEMENT] Impvoe the JSON collection script; now requires jq/yq #176
* [BUGFIX] Shell fixes for `collect-smartctl-json.sh` #178
* [BUGFIX] Various fixes to `collect_fake_json.sh` #159

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Mar 3, 2024
Merged
zxzharmlesszxz pushed a commit to zxzharmlesszxz/smartctl_exporter that referenced this pull request Mar 5, 2024
@k0ste @zxzharmlesszxz
collect-smartctl-json: shell fixes for script (prometheus-community#178)
e814261 
Signed-off-by: Konstantin Shalygin <[email protected]>
Signed-off-by: mort <[email protected]>
zxzharmlesszxz pushed a commit to zxzharmlesszxz/smartctl_exporter that referenced this pull request Mar 5, 2024
@k0ste @zxzharmlesszxz
collect-smartctl-json: shell fixes for script (prometheus-community#178)
b510db0 
Signed-off-by: Konstantin Shalygin <[email protected]>
Signed-off-by: Denys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0ste @SuperQ